tablesort appends _GET/_POST values to the headers, but does not do this for the pager links (prev, next). This can be very confusing when the table changes because the paramters change when a user goes to the next page.

Comments

moshe weitzman’s picture

moshe weitzman commented

Could you please replace tablesort_pager() with the following and assure
that it does what we want. It sounds like you have a real test case for this.

moshe weitzman’s picture

moshe weitzman commented

Sorry - last post got stripped. Here goes:

function tablesort_pager() {
  $cgi = $_SERVER['REQUEST_METHOD'] == 'GET' ? $_GET : $_POST;
  unset($cgi["q"], $cgi["from"]);
  return $cgi;
}
dries’s picture

dries commented

How about just using $_REQUEST instead of $_GET or $_POST?

moshe weitzman’s picture

moshe weitzman commented

Will do so. Speak up now if someone thinks this introduces a security weakness.

al’s picture

al commented

See also bug 1781 @ http://drupal.org/node/view/1781

moshe weitzman’s picture

moshe weitzman commented

fix committed to CVS last week