There is a typo in dblog_views_data(). The help text for the "type" field says "The of the log entry,..." when it should be "The type of the log entry,..."

I'll add a patch momentarily.

CommentFileSizeAuthor
#9 dblog-help-typo-2599374-9-D8.patch542 bytessagar ramgade
#2 dblog-help-typo-2599374-2-D8.diff543 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

JKerschner created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new dblog-help-typo-2599374-2-D8.diff543 bytes

A patch is attached. My apologies if it is named incorrectly; this is the best I could figure out based on the docs.

Anonymous’s picture

Anonymous (not verified) commented
Version: 8.0.0-rc2 » 8.0.0-rc3
Anonymous’s picture

Anonymous (not verified) commented

This patch was originally made for rc2, but the file seems to be unchanged in rc3 so the same patch should still work.

Anonymous’s picture

Anonymous (not verified) commented
Version: 8.0.0-rc3 » 8.0.x-dev
Anonymous’s picture

Anonymous (not verified) commented
Priority: Minor » Normal

Just actually found out what the different priorities are used for, and it looks like "Minor" is supposed to be even more minor than this.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
commented
Status: Needs review » Reviewed & tested by the community

#2 Patch works fine.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Needs work

Thanks @JKerschner for the patch!

Since this will break existing translations for this string, targeting against 8.1.x per https://www.drupal.org/core/d8-allowed-changes#minor.

+++ b/core/modules/dblog/dblog.views.inc
@@ -66,7 +66,7 @@ function dblog_views_data() {
-    'help' => t('The of the log entry, for example "user" or "page not found.".'),
+    'help' => t('The type of the log entry, for example "user" or "page not found.".'),

There is an extra period in there as well; let's fix both typos together.

sagar ramgade’s picture

sagar ramgade commented
Status: Needs work » Needs review
StatusFileSize
new dblog-help-typo-2599374-9-D8.patch542 bytes

Patch attached fixes the typo mentioned by xjm.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 742bf63 and pushed to 8.1.x. Thanks!

  • alexpott committed 742bf63 on 8.1.x 
    Issue #2599374 by JKerschner, Sagar Ramgade, xjm: Missing word "type" in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.