Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The Comment module now includes the option to configure different comment types. This is not covered in the hook_help text.
Proposed resolution
Update the hook_help text.
Check the UI text on the Comments and Comment types administration pages and update them if necessary as well.
Remaining tasks
Update the hook_help text, and possibly the UI text as well
User interface changes
This is a UI text change.
API changes
None.
Data model changes
None.
Beta phase evaluation
| Issue category | Task because it is adding a missing part to the Help text. |
|---|---|
| Issue priority | Minor |
| Unfrozen changes | Unfrozen because it only changes strings by adding another string to the hook_help(). |
| Disruption | None |
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2572525-comment-help-3.patch | 2.39 KB | marjadoedens |
Comments
Comment #2
marjadoedens CreditAttribution: marjadoedens at Wowww commentedI'll be working on this today.
Comment #3
ifrikApparently there is a usability issue #2496913: Don't expose entity types with string ids as a target option when creating comment types that hasn't been solved yet, even though I'm not quite sure whether this covers all of the problem.
Comment #4
ifrikLuckily, the issue mentioned above is of no concern to this issue.
Comment #5
marjadoedens CreditAttribution: marjadoedens at Wowww commentedI updated the help-text and added a use because the functionality was changed.
Comment #6
marjadoedens CreditAttribution: marjadoedens at Wowww commentedComment #7
ifrikThanks a lot for the patch - and for spending all the time with me to first find out how that part of the module even works :-)
This addition should save lots of sitebuilders a lot of time...
beta-evaluation added.
Comment #8
ifrikComment #9
ifrikThe UI text about adding Comment types on the administration pages looks correct.
Comment #11
jhodgdonSome random test failure. The added text looks good to me. +1.
Comment #12
xjmGreat to have this documented as this new feature might be confusing otherwise. The docs look good to me as well. Committed and pushed to 8.0.x.