Problem/Motivation

See: #2489460: [Meta] Move module.theme.css files to Classy or Seven

Proposed resolution

Move the CSS files to classy
Rename the files to remove the .theme. extension
Alter the system.base library so the CSS files are loaded with a similar weight to before

Remaining tasks

Test steps

Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file removed from the system module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS

User interface changes

None for Classy, Stark will be more Stark

API changes

None

CommentFileSizeAuthor
#13 interdiff-2553465-11-13.txt1.12 KBrainbowarray
#13 2553465-13-move-filters-more-pager-css-classy.patch2.38 KBrainbowarray
#11 interdiff-553465-10-11.txt1.86 KBrainbowarray
#11 2553465-11-move-filters-more-pager-to-classy.patch2.76 KBrainbowarray
#10 2553465-10-move-filters-more-pager-to-classy.patch2.38 KBrainbowarray
#7 interdiff-2553465-5-7.txt1.6 KBrainbowarray
#7 2553465-7-move-filters-more-pager-to-classy.patch3.02 KBrainbowarray
#7 2553465-6-move-filters-more-pager-to-classy.patch3.02 KBrainbowarray
#6 interdiff-2553465-5-6.txt4.93 KBrainbowarray
#6 2553465-6-move-filters-more-pager-to-classy.patch6.37 KBrainbowarray
#5 2553465-5-move-filters-more-pager-to-classy.patch5.73 KBrainbowarray
#4 move_system_css_to_classy-2553465-4.patch2.43 KBlewisnyman
#2 move_system_css_to_classy-2553465-2.patch2.77 KBpguillard

Comments

mdrummond created an issue. See original summary.

pguillard’s picture

pguillard commented
StatusFileSize
new move_system_css_to_classy-2553465-2.patch2.77 KB

Not complete, I don't know where to attach the library..

pguillard’s picture

pguillard commented
Status: Active » Needs review
lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Needs work
StatusFileSize
new move_system_css_to_classy-2553465-4.patch2.43 KB

Reroll after #977844: Remove the 'every_page' option for CSS/JS assets: it is confusing, even damaging 

  1. +++ b/core/themes/classy/classy.libraries.yml
+++ b/core/themes/classy/classy.libraries.yml
@@ -3,6 +3,9 @@ base:

@@ -3,6 +3,9 @@ base:
   css:
     theme:
       css/layout.css: {}
+      css/base/pager.theme.css: { every_page: true, weight: -10 }
+      css/base/more-link.theme.css: { every_page: true, weight: -10 }
+      css/base/exposed-filters.theme.css: { every_page: true, weight: -10 }

    Since we're not changing when these files are loaded, we can create a library called global-styling add load this library on every page. You can then load this library through the .info.yml file.

    See the Seven theme for an example. 

  2. +++ b/core/themes/classy/classy.libraries.yml
similarity index 100%
rename from core/modules/system/css/components/exposed-filters.theme.css

rename from core/modules/system/css/components/exposed-filters.theme.css
rename to core/themes/classy/css/base/exposed-filters.theme.css

    base has a very specific meaning in SMACSS: elements with no classes on them.

    If we follow the discussion in #2489566: move file.theme.css to classy then I would move these files into a 'components' folder.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs work » Needs review
StatusFileSize
new 2553465-5-move-filters-more-pager-to-classy.patch5.73 KB

Reroll.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2553465-6-move-filters-more-pager-to-classy.patch6.37 KB
new interdiff-2553465-5-6.txt4.93 KB

Here's a revised patch with the fixes suggested in #4.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2553465-6-move-filters-more-pager-to-classy.patch3.02 KB
new 2553465-7-move-filters-more-pager-to-classy.patch3.02 KB
new interdiff-2553465-5-7.txt1.6 KB

Fixed my git settings to reduce patch size.

The last submitted patch, 6: 2553465-6-move-filters-more-pager-to-classy.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2553465-7-move-filters-more-pager-to-classy.patch, failed testing.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs work » Needs review
StatusFileSize
new 2553465-10-move-filters-more-pager-to-classy.patch2.38 KB

Redoing the reroll. I screwed something up in here.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2553465-11-move-filters-more-pager-to-classy.patch2.76 KB
new interdiff-553465-10-11.txt1.86 KB

Hopefully this is a cleaner fix.

Status: Needs review » Needs work

The last submitted patch, 11: 2553465-11-move-filters-more-pager-to-classy.patch, failed testing.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs work » Needs review
StatusFileSize
new 2553465-13-move-filters-more-pager-css-classy.patch2.38 KB
new interdiff-2553465-11-13.txt1.12 KB

Using base instead of global-styling library.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

No visual changes on Bartik or Seven.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 7375a7b on 8.0.x 
    Issue #2553465 by mdrummond, pguillard, LewisNyman: Move system exposed-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.