Add cacheability metadata information to translation overview

Patch looks great! Just one remark.

+++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
@@ -78,6 +79,8 @@ public function overview(RouteMatchInterface $route_match, $entity_type_id = NUL
+    $cacheability = CacheableMetadata::createFromRenderArray([]);

No need for this, just

$cacheability = new CacheableMetadata();

will do.

Waiting for a fix for #5 to RTBC

Needs work, I guess :(

"Seems testbot is high and/or drunk." WTF? :D

I suspect something else on the page is already causing that cache context to be added, which would explain the lack of failures. You could choose to force the SimplePageVariant to look only at the cacheability of the render array returned by the controller.

Confirmed by applying content-translation-overview-cacheability-2500013-11-test-only.patch to HEAD, and running this test. It passes. So something else is already adding that cache context.

The idea in #17 also won't work; this already is using the SimplePageVariant. So, I don't think there's much more to test here.

Makes sense, but then why we had test failures in the parent issues?

I had the same question, so I worked on getting the SmartCache patch applying to HEAD again: #2429617-130: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!). Let's see what the answer is.

Nope, the failures in the translation workflow test still exist: #2429617-130: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!).

So, probably the test is not precise enough. I think it needs to be testing for the presence of some other cache context or some cache tag. Let's figure that out.

RTBC +1

RTBC + 1

Bumping to major given that this blocks #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!), which is major.

Added beta evaluation.

Committed 41cc210 and pushed to 8.0.x. Thanks!

Thanks for adding a beta evaluation.