Problem/Motivation

+++ b/core/modules/simpletest/src/RandomGeneratorTrait.php
@@ -0,0 +1,120 @@
+trait RandomGeneratorTrait {
Yay! Can we get a followup to use this in BrowserTestBase please?

There we go

Proposed resolution

In \Drupal\simpletest\BrowserTestBase

use RandomGeneratorTrait;

Remaining tasks

None.

User interface changes

None.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it's a cleanup that removes a code duplication.
Issue priority Not critical because it doesn't affect in the way Drupal works.
Disruption No disruption.
CommentFileSizeAuthor
#1 2499199-1.patch3.47 KBclaudiu.cristea

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2499199-1.patch3.47 KB

It should be a patch with only one green line, right? :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah this is exactly what is supposed to be needed.

Nice!

If you want you should do more research what is missing in BrowserTestBase in comparison with WebTestBase and see whether we can continuously port them over.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes

Beta evaluation

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Impressive diffstat. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 90b74e9 on 8.0.x 
    Issue #2499199 by claudiu.cristea, dawehner: Use RandomGeneratorTrait in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.