Update Backbone to 1.2.1

Big changes. Applying patch, top right edit button disappeared

Yeah their changelog is massive it's been more than a year since their last realease: http://backbonejs.org/#changelog

Too bad jessebeach is not around anymore.

It's a novice issue in the sense that a backbone dev should find it relatively easy to fix.

this issue: https://github.com/jashkenas/backbone/issues/3611

Only 2 places used this pattern, we can do code refactoring before upstream fixing. It's even more readability.

Need to add the unminified backbone source too (for the map file).

Updated issue summary.

Contextual links are working, toolbar, quickedit, ckeditor and the tour module as well.

Setting RTBC :) As already by @nod_, Also Tested patch locally,Ckeditor, toolbar is working fine :)

@nod_ should we not look into the reasons why the tests are failing before RTBC? or is this an exception.

patch failing

I have done a re-roll.

@dcmul: Can you tell me what you changed in the reroll. If you are able to please add an interdiff.txt.

diff --git a/core/assets/vendor/backbone/backbone.js b/core/assets/vendor/backbone/backbone.js
new file mode 100644

We do not need this file. We have backbone-min.js and backbone-min.map for that.

No we need it, the map file is useless without the original source. Needs to be in the patch.

OK I nod_ says we need the file then we need the file. To RTBC.

Back to RTBC.

Committed and pushed to 8.0.x. Thanks!

Thanks also for the manual testing. Always spooky when updating these JS libs. :)