Deprecate comment_view() & comment_view_multiple()

yep, looks great!

1. +++ b/core/modules/comment/comment.module
   @@ -553,7 +555,7 @@ function comment_preview(CommentInterface $comment, FormStateInterface $form_sta
   +    $comment_build = entity_view($comment, 'full', NULL);
   
   @@ -563,7 +565,7 @@ function comment_preview(CommentInterface $comment, FormStateInterface $form_sta
   +      $build = entity_view($parent, 'full', NULL);
   
   +++ b/core/modules/comment/src/Plugin/Action/UnpublishByKeywordComment.php
   @@ -27,7 +27,7 @@ class UnpublishByKeywordComment extends ConfigurableActionBase {
   +    $build = entity_view($comment, 'full', NULL);
   
   +++ b/core/modules/comment/src/Plugin/views/row/Rss.php
   @@ -106,7 +106,7 @@ public function render($row) {
   +    $build = entity_view($comment, 'rss', NULL);
   

   NULL is not needed

2. +++ b/core/modules/comment/src/Entity/Comment.php
   @@ -80,8 +80,7 @@ public function preSave(EntityStorageInterface $storage) {
   +      // Add the comment to database. This next section builds the thread field..
   

   nit, extra dot at the end

looks good now, let's get commiter feedback on this

@pguillard we deprecate it in 8.x but will remove in 9.x

+++ b/core/modules/comment/comment.module
@@ -232,6 +232,7 @@ function comment_node_view_alter(array &$build, EntityInterface $node, EntityVie
+ * @deprecated in Drupal 9.0.x-dev, will be removed before Drupal 9.0

@@ -253,6 +254,7 @@ function comment_view(CommentInterface $comment, $view_mode = 'full', $langcode
+ * @deprecated in Drupal 9.0.x-dev, will be removed before Drupal 9.0

Should be @deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0

Added beta evaluation

+++ b/core/modules/comment/comment.module
@@ -257,6 +257,7 @@ function comment_node_view_alter(array &$build, EntityInterface $node, EntityVie
+ * @deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0
  */

@@ -278,6 +279,7 @@ function comment_view(CommentInterface $comment, $view_mode = 'full', $langcode
+ * @deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0
  */

You forget to said that entity_view_* should be used instead

take a look at common.inc examples, you missed dots at the end

+++ b/core/modules/comment/comment.module
@@ -257,6 +257,8 @@ function comment_node_view_alter(array &$build, EntityInterface $node, EntityVie
+ * @deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0
+ *   entity_view() should be used instead

@@ -278,6 +280,8 @@ function comment_view(CommentInterface $comment, $view_mode = 'full', $langcode
+ * @deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0
+ *   entity_view_multiple() should be used instead

@deprecated in Drupal 8.0.0, will be removed before Drupal 9.0.0.
Use entity_view() instead.

thanx, not it's good to go

Suppose now it finally ready

This issue should be split into 4 issues, according what @xjm said in IRC about allowed beta changes.

This issue just deprecates functions, next to remove usage
Then 2 tasks:
1) clean-up broken comment
2) use proper service injections into plugins

1. +++ b/core/modules/comment/src/Entity/Comment.php
   @@ -81,7 +81,7 @@ public function preSave(EntityStorageInterface $storage) {
   -      // Also see the documentation for comment_view().
   +      // @see \Drupal\comment\CommentViewBuilder::buildComponents().
   

   this change should be separate issue 'cos comment_view() docs have nothing about threading

2. +++ b/core/modules/comment/src/Plugin/Action/UnpublishByKeywordComment.php
   @@ -21,14 +25,56 @@
   -    $build = comment_view($comment);
   -    $text = \Drupal::service('renderer')->renderPlain($build);
   +    $build = $this->entityManager->getViewBuilder('comment')->view($comment);
   +    $text = $this->renderer->renderPlain($build);
   
   +++ b/core/modules/comment/src/Plugin/views/row/Rss.php
   @@ -106,7 +106,7 @@ public function render($row) {
   -    $build = comment_view($comment, 'rss');
   +    $build = $this->entityManager->getViewBuilder('comment')->view($comment, 'rss');
   

   this needs separate issue, probably for 8.1.x otoh that minimize code fragility

Patch with deprecate only

Also filed:
#2526004: UnpublishByKeywordComment should inject needed services properly
#2526064: Remove usage of comment_view() & comment_view_multiple()
#2526084: Fix comment in Comment entity