Views UI text overlap in older versions of Firefox

I was working with ijf8090 on this in the sprints at Drupalcon. Looks like some of the fields in the second column ("Field Identifier" and "Allow Multiple Selections") aren't being wrapped in the wrapper correctly. I'm guessing they're supposed to be in the second column?

Good catch!

Did you tried creating a patch for this particular issue? https://www.drupal.org/node/707484 in case you need help how to create patches.

For me it seems to be a CSS-Issue. The float of the right column (views-right-60) needs to be cleared. I'll try to find a way to clear this without destroying anything.

Adding a patch to fix this issue.

Do you mind posting an image of before/after in the issue summary?

Here are the screenshots:

LTR before Patch:

LTR after Patch:

RTL before Patch:

RTL after Patch:

On a fresh drupal-8 installation the views CSS is overridden by the stable theme CSS. I changed both files so that any element gets cleared, not only DIVs.

See #2575737: Copy templates, CSS, and related assets to Stable and override core libraries' CSS

I tried reproducing the issue on Firefox, but it is displayed correctly on link http://localhost/drupal/admin/structure/views/view/content.
Screenshot has been attached for reference.

From what I can see this is a Firefox bug that was solved in Firefox 42. I was able to reproduce the behaviour only on Firefox 41 and earlier. The stable release as of this writing is 44.

I'm setting this back to needs review, I think this is a bit of a special case that needs more discussion, see also #2390621: [policy, no patch] Update Drupal's browser support policy.

@swati_qa from what you're saying you weren't able to reproduce this either - for future reference the "Reviewed & tested by the community" status shouldn't be used when the bug the patch is trying to solve can't be reproduced: https://www.drupal.org/node/156119#rtbc. Generally we would use "Closed (duplicate)" if the bug has been confirmed fixed or "Closed (cannot reproduce)" if the bug reported was never able to be reproduced (but this one was able to be reproduced at least at one point!).

Tested patch text_layout_issue_s-2489660-11.patch as mentioned in #11 for Firefox 41.
I was able to reproduce the issue there.
Steps followed:
1. Login as ADMIN.
2. Navigate to admin/structure/views/view/content
3. Select Content: Publishing status (grouped)

Screenshots have been attached for reference.
The issue still persists on Firefox 41 after patch was applied.
Also, issue is not reproducible on Firefox 44.
As patch fails testing, moving the issue to "Needs Work".

@swati_qa thanks for that testing!

Adding the fix.

Tested patch text-layout-issue-views-2489660-19.patch mentioned in #19 for Firefox 41.

Steps followed:
1. Login as ADMIN.
2. Navigate to admin/structure/views/view/content
3. Select Content: Publishing status (grouped)

Issue is working fine on Firefox 41.0 after patch was applied in RTL as well as LTR.
Screenshots attached for both views.
Issue is fixed for Firefox 41.0, so moving to RTBC.

In #15 @Cottser wrote:

I'm setting this back to needs review, I think this is a bit of a special case that needs more discussion, see also #2390621: [policy, no patch] Update Drupal's browser support policy

So do we fix this or not? Assigning to Cottser.

I like the fix in #19 more than the previous one and I don't see any harm/risk here so I think in this case we should fix it.

Committed and pushed f959540 to 8.2.x and f98c708 to 8.1.x. Thanks!