Problem/Motivation
The EntityFile destination plugin copies files from one place to another. At the moment, it doesn't check if the source path actually exists, which means that copy() might eventually be called with an invalid source path. When it returns FALSE in that circumstance, the user will get a profoundly unhelpful "file could not be copied" exception.
Proposed Resolution
Before doing anything else, EntityFile should check if the source file actually exists, and throw a helpful exception if it doesn't.
Remaining Tasks
Discuss, then create a patch if needed.
API Changes
None.
UI Changes
None.
Comments
Comment #1
phenaproximaDowngrading priority.
Comment #2
phenaproximaFirst stab at a patch.
Comment #3
phenaproximaHave at it, testbot!
Comment #5
phenaproximaBecause this patch intersects largely with the work being done in #2417975: EntityFile destination incorrectly assumes temporary files are absolute paths, I'm merging it into that one.