Problem/Motivation

The Activity Tracker (tracker module) refers to comments as "replies" in its tables, for example on /activity. Since "comments" is the term that's used accross a Drupal site, it should be "comments" here as well.

If the tracker listing is replaced by a view then this issue might be obsolete #1941830: Convert tracker listings to a view.

Proposed resolution

Replace "replies" by "comments" in the activity tables.

Remaining tasks

User interface changes

The hook_help text for the tracker module already talks about comments. If this issue does not get fixed, then the help text needs to be changed.

API changes

CommentFileSizeAuthor
#1 tracker-replies-comments-2471729.patch944 bytesdrubb

Comments

drubb’s picture

StatusFileSize
new944 bytes

Here's a first patch to achieve this.

drubb’s picture

Status: Active » Needs review
ifrik’s picture

Thanks drubb,

The table now displays the "comment" as table header in both tables.

The patch only changes the display of the table header.

ifrik’s picture

Status: Needs review » Reviewed & tested by the community
ifrik’s picture

Issue tags: +drupaldevdays
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yep, I honestly can't think of a good reason for this inconsistency.

If we wanted to be super careful, we could not rename the table header in case some module somewhere is modifying that tracker table, but I highly doubt it.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 19d0b18 on 8.0.x
    Issue #2471729 by drubb, ifrik: Tracker module refers to replies instead...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.