From #2323531-5: Imagemagick port to Drupal 8:

Problem/Motivation

The plugin isn't picked up after a module install, because the plugin managers aren't following the plugin.manager naming pattern, so the plugin_manager_cache_clear tag would need to be added those.

Proposed resolution

Add plugin_manager_cache_clear tag to image.toolkit.manager and image.toolkit.operation.manager.

Remaining tasks

  • Review patch

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2467775-1.patch710 bytesmondrake

Comments

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned
Issue summary: View changes
StatusFileSize
new 2467775-1.patch710 bytes
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Good catch.

Can anyone say if we test for this type of integration and if so, how? I tried to find a test that does this, but couldn't find any.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me as well. #2419005: Aggregator: Uncaught PHP Exception Drupal\Component\Plugin\Exception\PluginNotFoundException: "The "FeedTitle" plugin does not exist." was a similar problem, and it added a pretty weird test IMHO. I think this is OK, the worst case is that a manual cache clear is enabled after installing the module.

Let's see what core committers think about test coverage.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

We know that the plugin_manager_cache_clear functionality works and is tested - I'm okay with not adding a specific test.

Committed 79be8cf and pushed to 8.0.x. Thanks!

  • alexpott committed 79be8cf on 8.0.x 
    Issue #2467775 by mondrake: Contrib toolkits are not picked up after...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.