Remove config_test_load() and replace with entity_load

1. +++ b/core/modules/config/tests/config_test/src/ConfigTestForm.php
   @@ -33,7 +33,7 @@ public function form(array $form, FormStateInterface $form_state) {
          '#required' => TRUE,
          '#machine_name' => array(
   -        'exists' => 'config_test_load',
   +        'exists' => $this->entity->getEntityType()->getClass() . '::load',
            'replace_pattern' => '[^a-z0-9_.]+',
   

   Dynamic code to get the class name to call it statically so that we can dynamically figure out the entity type still feels a bit weird to me.

   It was hardcoded before, so why not just hardcode it now?

2. +++ b/core/modules/config/tests/config_test/src/Entity/ConfigQueryTest.php
   @@ -21,6 +21,7 @@
     *   },
     *   config_prefix = "query",
   + *   class = "Drupal\config_test\Entity\ConfigQueryTest",
   

   This won't change anything. The class is automatically set.

This issue doesn't mention config_test_entity_type_alter() anywhere.

This is by design then, there's nothing wrong. We know that ::load() doesn't work when an entity class is re-used multiple times, that's a pretty weird thing to do and I don't see why that makes sense here, we should just define it as a proper annotated class.

There are uses to re-use a class, for example to deal with a dynamic entity types or entity types that are exposed from a third party system, but this isn't a valid use case. Someone was just lazy.

Patch no longer applied cleanly. Created a new patch and replaced entity_load with the entity storage's load method because those will be marked deprecated for 9.0.0. in #2474151: Mark procedural wrappers in entity.inc as deprecated.

Wrong patch. This is the right one.

1. +++ b/core/modules/config/tests/config_test/src/ConfigTestForm.php
   @@ -33,7 +33,7 @@ public function form(array $form, FormStateInterface $form_state) {
   +        'exists' => [get_class($this), 'exists'],
   

   Just use [$this, 'exists'], and then everything will be cleaner below

2. +++ b/core/modules/config/tests/config_test/src/ConfigTestForm.php
   @@ -142,4 +142,25 @@ public function save(array $form, FormStateInterface $form_state) {
   +    return (bool) \Drupal::entityQuery($entity->getEntityTypeId())
   

   Either inject entity query, or use $this->entityManager->getStorage($entity_type_id)->getQuery()

@tim.plunkett, hmm, I think it was done this way, because exists is a static method and $this is not available in it.

Yes, and I'm saying make it non-static, like the other exists() methods in forms.

Alright, changed the method to a non-static method.

Patch attached.

Thanks!

1. +++ b/core/modules/config/tests/config_test/src/ConfigTestForm.php
   @@ -16,6 +18,32 @@
   +   * Constructs a new ConfigImportForm.
   

   Wrong class name

2. +++ b/core/modules/config/tests/config_test/src/ConfigTestForm.php
   @@ -16,6 +18,32 @@
   +    $this->$entityQuery = $entity_query;
   

   $this->entityQuery

Fixed mentioned in #18

Not uploading any interdiff as it is just correction suggested by @tim.plunkett

Great, thanks!

By definition this affect test only code and therefore is permitted in beta. Committed aecc5a4 and pushed to 8.0.x. Thanks!