When viewing a page built with a non-default theme with the quickedit module enabled, the ajax_page_state's theme key mysteriously gets switched to the default theme. As a result, any ajax calls that follow pass through the default theme, not the overrridden theme.
Fix the quickedit.attachments route to use the ajax_base_page theme attribute, which seems to be the only way the theme negotiator can tell it's an ajaxy route.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2404199-quickedit_attachments_route_theme_negotiation-3.patch | 499 bytes | rbayliss |
| #1 | 2404199-quickedit_attachments_route_theme_negotiation-1.patch | 564 bytes | rbayliss |
Comments
Comment #1
rbayliss commentedComment #3
rbayliss commentedReroll. This is still an issue, albeit a bit of an edge case.
Comment #5
dawehnerA bug should be fixed in 8.0.x
Comment #7
wim leersPatch looks great; can we add a small bit of test coverage?
Comment #9
wim leersWoot, as of #2745953: AjaxBasePageNegotiator should not require _theme: ajax_base_page to be specified this is no longer necessary! :)
Comment #10
wim leers