Problem/Motivation
For some external reasons the <none> route does not work as expected.
It prints out "/subdir#fragment" instead of "#fragment".
Proposed resolution
Explicit allow in the url generator to force a fragment, if needed.
Remaining tasks
User interface changes
API changes
<none> now works as expected.
... RouteProcessorNone is no longer needed
Beta phase evaluation
| Issue category | Bug, because it does not work as intended |
|---|---|
| Issue priority | Critical, |
| Disruption | No discruption |
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2401395-8.patch | 6.27 KB | dawehner |
| #8 | interdiff.txt | 4.24 KB | dawehner |
| #4 | interdiff.txt | 805 bytes | dawehner |
| #4 | 2401395-4.patch | 4.36 KB | dawehner |
| #2 | 2401395-2.patch | 3.57 KB | dawehner |
Comments
Comment #1
dawehnerLet's start with the existing broken tests.
Comment #2
dawehnerAlright.
Comment #4
dawehnerWow, this indeed broke something.
Comment #5
dawehnerAdded a beta EV and an IS.
Comment #6
berdirRight now,
<none>is the same as<front>, which means that it is not really useful. This changes it to something different, that in some situations is useful, we need to add back a test in #2350837: Convert most usages of EntityInterface::getSystemPath() to use routes, for example.Created a small change notice, this wasn't added here but I did not found it mentioned anywhere in an existing one, only
<current>and<front>.Comment #8
dawehner@alexpott suggested to use '_only_fragment'
@dawehner suggested to get rid of RouteProcessorNone.
Comment #9
alexpottI think the altered approach needs a new rtbc.
Comment #10
berdirLooks nice!
Comment #11
alexpottWe should update the documentation on https://www.drupal.org/node/2092643.
Committed 3ac9d4c and pushed to 8.0.x. Thanks!