Problem/Motivation

For some external reasons the <none> route does not work as expected.
It prints out "/subdir#fragment" instead of "#fragment".

Proposed resolution

Explicit allow in the url generator to force a fragment, if needed.

Remaining tasks

User interface changes

API changes

<none> now works as expected.
... RouteProcessorNone is no longer needed

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug, because it does not work as intended
Issue priority Critical,
Disruption No discruption

Comments

dawehner’s picture

StatusFileSize
new2.41 KB

Let's start with the existing broken tests.

dawehner’s picture

Status: Active » Needs review
Issue tags: +WSCCI
StatusFileSize
new1.16 KB
new3.57 KB

Alright.

Status: Needs review » Needs work

The last submitted patch, 2: 2401395-2.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new4.36 KB
new805 bytes

Wow, this indeed broke something.

dawehner’s picture

Issue summary: View changes

Added a beta EV and an IS.

berdir’s picture

Title: <none> does not work as expected with fragments. » <none> does not work as expected with fragments
Status: Needs review » Reviewed & tested by the community

Right now, <none> is the same as <front>, which means that it is not really useful. This changes it to something different, that in some situations is useful, we need to add back a test in #2350837: Convert most usages of EntityInterface::getSystemPath() to use routes, for example.

Created a small change notice, this wasn't added here but I did not found it mentioned anywhere in an existing one, only <current> and <front>.

The last submitted patch, 1: 2401395-1.patch, failed testing.

dawehner’s picture

Issue summary: View changes
StatusFileSize
new4.24 KB
new6.27 KB

@alexpott suggested to use '_only_fragment'
@dawehner suggested to get rid of RouteProcessorNone.

alexpott’s picture

Status: Reviewed & tested by the community » Needs review

I think the altered approach needs a new rtbc.

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Looks nice!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

We should update the documentation on https://www.drupal.org/node/2092643.

Committed 3ac9d4c and pushed to 8.0.x. Thanks!

  • alexpott committed 3ac9d4c on 8.0.x
    Issue #2401395 by dawehner: <none> does not work as expected with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.