Followup for #2238085: [regression] options_allowed_values() signature doesn't allow for Views filter configuration :

- fixes the part about the $cacheable param, which is incorrect
- expands the explanation about $entity / no $entity a bit
- fixes the code sample to actually comply to the recommendations in the doc (allowed values for a specific $entity should be a subset of the values for "no specific entity")

Comments

yched’s picture

Issue summary: View changes
StatusFileSize
new3.8 KB
yched’s picture

Status: Active » Needs review
xjm’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Ghent DA sprint

@yched and I went over this text together and it's definitely better now.

xjm’s picture

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ec4b697 and pushed to 8.0.x. Thanks!

  • alexpott committed ec4b697 on 8.0.x
    Issue #2393061 by yched: Adjust phpdoc for...

Status: Fixed » Needs work

The last submitted patch, 1: 2393061-callback_allowed_values_function-1.patch, failed testing.

xjm’s picture

Status: Needs work » Fixed

Silly bot is silly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.