Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Recent core changes added strictness to schema. Now it is impossible to add new items to the system.mail:interface
mapping.
Proposed resolution
Change type of system.mail:interface
to sequence.
Remaining tasks
There might be other configs that have the same problem?
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#5 | mail-interface-schema-2392427-5.interdiff.txt | 563 bytes | Arla |
#5 | mail-interface-schema-2392427-5.patch | 2.1 KB | Arla |
#1 | mail-interface-schema-2392427-1.patch | 2.08 KB | Arla |
#1 | mail-interface-schema-2392427-1-TEST_ONLY.patch | 1.46 KB | Arla |
Comments
Comment #1
ArlaA test to prove the point, and a fix that changes the type to sequence.
Comment #2
Gábor HojtsySo what is stored there? Are all of those settings for sure?
Comment #3
Gábor Hojtsy@berdir pointed to MailManager::getInstance():
So it is indeed a list of arbitrary strings. The patch seems to be good. The reason it was not caught before is because we only had a phpunit test for this, no integration test.
Comment #4
Gábor HojtsyI would call them 'Interfaces' and 'Interface', that is what we do elsewhere. We don't need to change the key names, but the labels we have more free control over :)
Comment #5
ArlaAha, I got "Individual interface" from your schema cheat-sheet ;)
Comment #6
BerdirInterface is a pretty weird thing anyway, not sure what that means exactly, in the past, we stored class names (implementations, not interfaces) and what we are storing there now are plugin IDs.
Not sure what to do about that with the labels, having something completely different in the labels is also weird.
Comment #7
Gábor HojtsyLOL I will fix that individual thing in a new version later :D It will need 1 line moved...
Comment #9
BerdirI think this is good to go.
Not sure if it's just normal, it's at breaking the ability to use this in tests, which means it's blocking contrib module tests.
Comment #10
alexpottI think this is a major bug.
This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 2a7aaa0 and pushed to 8.0.x. Thanks!
Comment #12
tstoeckler