This issue is part of #2157455: [Meta] Make Drupal 8 work with PostgreSQL or remove support from core before release.

Currently there is one or more fail or exception in the entity_reference test group identified by the new docker based testbot that need to be fixed to make PostgreSQL finally passing all tests. Command in use:

sudo DCI_DBTYPE='pgsql' \
DCI_DBVER='9.1' \
DCI_PHPVERSION='5.5' \
DCI_CONCURRENCY='4' \
DCI_TESTGROUPS='entity_reference' \
DCI_DRUPALBRANCH='8.0.x' \
DCI_VERBOSE='true' \
DCI_UPDATEREPO='true' \
./containers/web/run.sh

The patch from #1013034-67: PostgreSQL constraints do not get renamed by db_rename_table() fixes this test on PostgreSQL

CommentFileSizeAuthor
entity_reference_group_tests.txt85.71 KBbzrudi71

Comments

bzrudi71’s picture

bzrudi71 commented
Issue summary: View changes

There is a FATAL that I have overseen ;-)

jaredsmith’s picture

jaredsmith commented

This fatal is being caused because the call to FieldConfigStorage::loadByProperties on line 38 in core/modules/config/src/Tests/AssertConfigEntityImportTrait.php is returning FALSE, indicating that it can't find a entity with that UUID.

I haven't yet figured out why that's failing.

bzrudi71’s picture

bzrudi71 commented

Nice! Seems we have 100% pass with #1013034: PostgreSQL constraints do not get renamed by db_rename_table() applied and the FATAL is gone. @jaredsmith: Can you please cross test this before marking as (patch avail, 100% pass, needs review)? Thanks!

jaredsmith’s picture

jaredsmith commented
Issue summary: View changes

I have re-tested the entity_reference test group with the patch from #1013034-65: PostgreSQL constraints do not get renamed by db_rename_table(), using the folowing parameters:

DCI_PHPVERSION=5.5
DCI_DRUPALBRANCH=8.0.x
DCI_TESTGROUPS=entity_reference
DCI_UPDATEREPO=TRUE
DCI_DBTYPE=pgsql
DCI_DBVER=9.1
DCI_PATCH=https://www.drupal.org/files/issues/pgsql-constraint-rename-1013034-65.p...,.

With that patch, the tests pass:

Test run started:
Tuesday, February 17, 2015 - 11:47

Test summary
------------
Drupal\entity_reference\Tests\EntityReferenceFieldTranslated 13 passes
Drupal\entity_reference\Tests\EntityReferenceAutoCreateTest 25 passes
Drupal\entity_reference\Tests\EntityReferenceFieldDefaultVal 24 passes
Drupal\entity_reference\Tests\Views\EntityReferenceRelations 38 passes
Drupal\entity_reference\Tests\Views\SelectionTest 6 passes
Drupal\field\Tests\EntityReference\EntityReferenceFormatterT 44 passes
Drupal\entity_reference\Tests\EntityReferenceAdminTest 121 passes
Drupal\system\Tests\Entity\EntityReferenceSelection\EntityRe 8 passes
Drupal\field\Tests\EntityReference\EntityReferenceItemTest 44 passes
Drupal\entity_reference\Tests\EntityReferenceIntegrationTest 161 passes
Drupal\system\Tests\Entity\EntityReferenceSelection\EntityRe 69 passes

Test run duration: 1 min 57 sec

bzrudi71’s picture

bzrudi71 commented

Cool :-) Thanks a lot!

jaredsmith’s picture

jaredsmith commented
Parent issue: #2386379: PostgreSQL: Fix tests in book test group »

Re-ran the pgsql tests with the updated patch from comment 67 at #1013034-67: PostgreSQL constraints do not get renamed by db_rename_table(), and all of the tests pass as expected.

Updating the parent issue and related issues as well.

jaredsmith’s picture

jaredsmith commented
Issue summary: View changes

Fixing the issue summary and related issues

jaredsmith’s picture

jaredsmith commented
Status: Active » Fixed

Now that the patch from #1013034: PostgreSQL constraints do not get renamed by db_rename_table() has been committed, I've re-tested this test group without any patches applied, and it passes all the tests. Marking as fixed.

Test run started:
Monday, February 23, 2015 - 14:51

Test summary
------------
Drupal\entity_reference\Tests\EntityReferenceAutoCreateTest 25 passes
Drupal\entity_reference\Tests\EntityReferenceFieldDefaultVal 24 passes
Drupal\entity_reference\Tests\EntityReferenceFieldTranslated 13 passes
Drupal\entity_reference\Tests\Views\EntityReferenceRelations 38 passes
Drupal\entity_reference\Tests\Views\SelectionTest 6 passes
Drupal\field\Tests\EntityReference\EntityReferenceFormatterT 44 passes
Drupal\entity_reference\Tests\EntityReferenceAdminTest 121 passes
Drupal\field\Tests\EntityReference\EntityReferenceItemTest 44 passes
Drupal\system\Tests\Entity\EntityReferenceSelection\EntityRe 8 passes
Drupal\entity_reference\Tests\EntityReferenceIntegrationTest 161 passes
Drupal\system\Tests\Entity\EntityReferenceSelection\EntityRe 69 passes

Test run duration: 2 min 17 sec

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.