Remove usage of file_stream_wrapper_get_instance_by_uri()

@kallehauge you must change the Status to "Needs review" to test the patch.

1. +++ b/core/lib/Drupal/Core/File/MimeType/MimeTypeGuesser.php
   @@ -37,7 +37,7 @@ class MimeTypeGuesser implements MimeTypeGuesserInterface {
   -    if ($wrapper = file_stream_wrapper_get_instance_by_uri($path)) {
   +    if ($wrapper = \Drupal::service('stream_wrapper_manager')->getViaUri($path)) {
   

   OO code - this should be injected

2. +++ b/core/modules/image/src/Entity/ImageStyle.php
   @@ -221,7 +221,7 @@ public function buildUrl($path, $clean_urls = NULL) {
   -      $directory_path = file_stream_wrapper_get_instance_by_uri($uri)->getDirectoryPath();
   +      $directory_path = \Drupal::service('stream_wrapper_manager')->getViaUri($uri)->getDirectoryPath();
   

   OO code - this should be injected

Looks good other than the lack of dependency injection. It is correct to not remove the function itself at this stage, I've updated the issue summary to clarify.

Is the create method in MimeTypeGuesser really necessary?

We already pass the streamWrapperManager in core.services.yml so I think that's enough.

Umm... thank you :)

#8 didn't remove the interface, just the method being implemented. This will need a change record.

I've not really debugged those failures, but I noticed #2353357: hook_stream_wrappers_alter() should be removed as it is broken since modules are not loaded on demand which could be related.

#2392559: Remove all uses of file_stream_wrapper_get_* and file_get_stream_wrappers