content_translation.settings config is not scalable

:-)

#2355909: language.settings config is not scalable is in.

Use ContentLanguageSettings third party settings storage. Kept the functions for now, not sure if we want to leave them, deprecate them or remove them.

PS: IMHO we should remove them before it is too late.

+1 to deprecate procedural wrappers
PS: There's actually a few failures

I didn't know that you need to provide a schema for third_party settings, but makes lots of sense.

Found this @todo:

/**
 * Determines whether the given entity type is translatable.
 *
 * @param string $entity_type
 *   The type of the entity.
 * @param string $bundle
 *   (optional) The bundle of the entity. If no bundle is provided, all the
 *   available bundles are checked.
 *
 * @returns
 *   TRUE if the specified bundle is translatable. If no bundle is provided
 *   returns TRUE if at least one of the entity bundles is translatable.
 *
 * @todo Move to \Drupal\content_translation\ContentTranslationManager.
 */
function content_translation_enabled($entity_type, $bundle = NULL) {

Proposal:

Remove:

• content_translation_enabled()
• content_translation_set_config()
• content_translation_get_config()
• content_translation_get_config_key()

Add:

• ContentTranslationManager::enable($entity_type, $bundle) : void
• ContentTranslationManager::disable($entity_type, $bundle) : void
• ContentTranslationManager::isEnabled($entity_type, $bundle) : bool

That was not my fault... We are supposed to be using existing entities.

Removing:

• content_translation_enabled()
• content_translation_set_config()
• content_translation_get_config()
• content_translation_get_config_key()

Adding:

• ContentTranslationManager::enable($entity_type, $bundle) : void
• ContentTranslationManager::disable($entity_type, $bundle) : void
• ContentTranslationManager::setEnabled($entity_type_id, $bundle, $value) : void
• ContentTranslationManager::isEnabled($entity_type, $bundle) : bool

Nice :)

1. +++ b/core/modules/content_translation/content_translation.admin.inc
   @@ -74,7 +74,7 @@ function _content_translation_form_language_content_settings_form_alter(array &$
   +    $default[$entity_type_id] = $enabled || \Drupal::service('content_translation.manager')->isEnabled($entity_type_id) ? $entity_type_id : FALSE;
   
   @@ -118,7 +118,7 @@ function _content_translation_form_language_content_settings_form_alter(array &$
   +            '#default_value' => \Drupal::service('content_translation.manager')->isEnabled($entity_type_id, $bundle),
   
   @@ -313,7 +313,7 @@ function content_translation_form_language_content_settings_submit(array $form,
   +        \Drupal::service('content_translation.manager')->setEnabled($entity_type_id, $bundle, $bundle_settings['translatable']);
   

   Can we retrieve the content manager just once and save it in a $manager variable? That would improve readability.

2. +++ b/core/modules/content_translation/src/ContentTranslationManagerInterface.php
   @@ -31,4 +31,52 @@ public function getSupportedEntityTypes();
   +  public function enable($entity_type_id, $bundle);
   ...
   +  public function disable($entity_type_id, $bundle);
   ...
   +  public function setEnabled($entity_type_id, $bundle, $value);
   

   I agree with Gabor, having the three methods is confusing. I'd keep only the setter.

[edit : never mind, @Gabor was quicker than me]

Adressing #16, #17, #18.

Fixed.

Awesome work!

RTBC +1

This looks fantastic. One very small thing.

+++ b/core/modules/content_translation/src/ContentTranslationManager.php
@@ -52,4 +53,32 @@ public function getSupportedEntityTypes() {
+    $config = ContentLanguageSettings::loadByEntityTypeBundle($entity_type_id, $bundle);
...
+        $config = ContentLanguageSettings::loadByEntityTypeBundle($entity_type_id, $bundle);

Let's not use the static functions here. We should add a protected method to load everything from the already injected entity manager.

  protected function loadContentLanguageSettings($entity_type_id, $bundle) {
    if ($entity_type_id == NULL || $bundle == NULL) {
      return NULL;
    }
    $config = $this->entityManager->getStorage('language_content_settings')->load($entity_type_id . '.' . $bundle);
    if ($config == NULL) {
      $config = $this->entityManager->getStorage('language_content_settings')->create(['target_entity_type_id' => $entity_type_id, 'target_bundle' => $bundle]);
    }
    return $config;
  }

Fixed #24.

@Gábor Hojtsy those static loaders should not be used in injected classes - they obscure dependencies and prevent simple unit testing.

+++ b/core/modules/content_translation/src/ContentTranslationManager.php
@@ -52,4 +53,55 @@ public function getSupportedEntityTypes() {
+   * @return $this
+   *   The content language config entity if one exists. Otherwise, returns
+   *   default values.

This does not return $this - it returns the config entity.

The related issue should be in-sync with this one

Good catch, fixed the return type doc.

We should have a d8 to d8 CR record for this to help existing multilingual sites. That CR should reference https://www.drupal.org/node/2382481

Looks great

Committed 4efd487 and pushed to 8.0.x. Thanks!