Meta Issue: #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

CommentFileSizeAuthor
#8 2361745-8.patch11.14 KBrpayanm
#4 2361745-3.patch27.33 KBjavivf
#1 2361745-1.patch11.33 KBrpayanm

Comments

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 2361745-1.patch11.33 KB
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Assigned: rpayanm » Unassigned
javivf’s picture

javivf commented

The patch applies now

javivf’s picture

javivf commented
StatusFileSize
new 2361745-3.patch27.33 KB

rpayanm queued 4: 2361745-3.patch for re-testing.

filijonka’s picture

filijonka commented

hi

I'm a bit confused here why this second patch appears? The issue is to replace all truncate_utf() which the first patch does, the second patch does a whole lot of other stuff to and there is no interdiff so hard to say what's going on.

filijonka’s picture

filijonka commented
Status: Needs review » Needs work

pathc #4 is interfering with this issue #2355187: Remove form_get_cache() so this patch is doing to much

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2361745-8.patch11.14 KB

here the reroll :)

filijonka’s picture

filijonka commented

hi

1. This dunction isn't named in the meta but I assume it should be deprecated so it would perhaps be good if added to the meta-list

2. we still needs interdiffs so we know what's going on between the comments, see https://www.drupal.org/documentation/git/interdiff

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

No occurrences left and patch looks ok to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (removal of deprecated code) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed ea325a9 and pushed to 8.0.x. Thanks!

  • alexpott committed ea325a9 on 8.0.x 
    Issue #2361745 by rpayanm, javivf: Remove usage of truncate_utf8().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.