CommentFileSizeAuthor
#26 interdiff.txt3.43 KBpenyaskito
#26 2360245-26.patch90.18 KBpenyaskito
#25 2360245-25.patch90.21 KBpenyaskito
#25 interdiff.txt1.36 KBpenyaskito
#24 interdiff.txt1.14 KBpenyaskito
#24 2360245-24.patch90.61 KBpenyaskito
#22 interdiff.txt1.66 KBpenyaskito
#22 2360245-22.patch90.58 KBpenyaskito
#20 interdiff.txt6.85 KBpenyaskito
#20 2360245-20.patch90.4 KBpenyaskito
#18 interdiff.txt1.52 KBpenyaskito
#18 2360245-18.patch88.83 KBpenyaskito
#16 interdiff.txt7.39 KBpenyaskito
#16 2360245-16.patch88.04 KBpenyaskito
#15 interdiff.txt2.57 KBpenyaskito
#15 2360245-15.patch87.54 KBpenyaskito
#13 interdiff.txt3.2 KBpenyaskito
#13 2360245-13.patch87.24 KBpenyaskito
#11 interdiff.txt17.15 KBpenyaskito
#11 2360245-11.patch86.01 KBpenyaskito
#10 interdiff.txt807 bytespenyaskito
#10 2360245-10.patch12.19 KBpenyaskito
#8 interdiff.txt2.43 KBpenyaskito
#8 2360245-8.patch12.2 KBpenyaskito
#5 interdiff.txt9.29 KBpenyaskito
#5 2360245-5.patch12.12 KBpenyaskito
#2 interdiff.txt3.98 KBpenyaskito
#2 2360245-2.patch13.65 KBpenyaskito
#1 2360245-1.patch13.27 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Active » Needs review
FileSize
2360245-1.patch13.27 KB
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-2.patch13.65 KB
interdiff.txt3.98 KB

The last submitted patch, 1: 2360245-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2360245-2.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-5.patch12.12 KB
interdiff.txt9.29 KB
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: 2360245-5.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-8.patch12.2 KB
interdiff.txt2.43 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2360245-8.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-10.patch12.19 KB
interdiff.txt807 bytes

Should be green.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-11.patch86.01 KB
interdiff.txt17.15 KB

Replaced language_get_default_configuration() calls.

Status: Needs review » Needs work

The last submitted patch, 11: 2360245-11.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-13.patch87.24 KB
interdiff.txt3.2 KB

Use ContentLanguageSettings in the language_configuration element and forms.

Status: Needs review » Needs work

The last submitted patch, 13: 2360245-13.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-15.patch87.54 KB
interdiff.txt2.57 KB

Fix VocabularyLanguageTest

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-16.patch88.04 KB
interdiff.txt7.39 KB

Removed completely language_get_default_configuration()

Status: Needs review » Needs work

The last submitted patch, 16: 2360245-16.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-18.patch88.83 KB
interdiff.txt1.52 KB

Tricky call in node form... It was not a hook!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-20.patch90.4 KB
interdiff.txt6.85 KB

This was a pattern, moved that to hook_form_alter. Removing code++

Status: Needs review » Needs work

The last submitted patch, 20: 2360245-20.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-22.patch90.58 KB
interdiff.txt1.66 KB

Ok, we only need to alter if the entity is translatable.

Status: Needs review » Needs work

The last submitted patch, 22: 2360245-22.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs work » Needs review
FileSize
2360245-24.patch90.61 KB
interdiff.txt1.14 KB

Ok, we only need to alter if the entity TYPE is translatable.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
interdiff.txt1.36 KB
2360245-25.patch90.21 KB

We can remove code in BlockContentForm too.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
FileSize
2360245-26.patch90.18 KB
interdiff.txt3.43 KB

Use assertTrue when possible.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented

Posted patch #2355909-117: language.settings config is not scalable on main issue.

The last submitted patch, 18: 2360245-18.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Status: Needs review » Closed (fixed)

Parent has been committed.