Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
postgresql db driver
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Oct 2014 at 12:11 UTC
Updated:
9 Mar 2015 at 14:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bzrudi71 commentedDuplicate index/table (already exists) :-(
Comment #2
jaredsmith commentedI have tested this locally using the PostgreSQL support in drupalci. I was using PHP 5.5 and PostgreSQL 9.1
Before applying the patch from #2425127: Prevent PostgreSQL from creating duplicated index names within schema, got an exception in the OptionsFloatFieldImportTest test.
Test summary
------------
Drupal\options\Tests\OptionsFieldTest 18 passes 1 exceptions
Drupal\options\Tests\OptionsDynamicValuesApiTest 3 passes
Drupal\options\Tests\OptionsDynamicValuesValidationTest 9 passes
Drupal\options\Tests\OptionsFormattersTest 10 passes
Drupal\options\Tests\OptionsSelectDynamicValuesTest 16 passes
Fatal error: Call to a member function getSetting() on a non-object in /var/www/core/modules/options/src/Tests/OptionsFloatFieldImportTest.php on line 74
FATAL Drupal\options\Tests\OptionsFloatFieldImportTest: test runner returned a non-zero error code (255).
Drupal\options\Tests\OptionsWidgetsTest 211 passes
Drupal\options\Tests\OptionsFieldUITest 295 passes
Test run duration: 2 min 32 sec
After applying the patch from #2425127: Prevent PostgreSQL from creating duplicated index names within schema, the exception goes away and all the tests pass:
Test summary
------------
Drupal\options\Tests\OptionsFieldTest 21 passes
Drupal\options\Tests\OptionsDynamicValuesApiTest 3 passes
Drupal\options\Tests\OptionsDynamicValuesValidationTest 9 passes
Drupal\options\Tests\OptionsFormattersTest 10 passes
Drupal\options\Tests\OptionsSelectDynamicValuesTest 16 passes
Drupal\options\Tests\OptionsFloatFieldImportTest 33 passes
Drupal\options\Tests\OptionsWidgetsTest 211 passes
Drupal\options\Tests\OptionsFieldUITest 295 passes
Test run duration: 2 min 28 sec
I've also reviewed the code from that patch, and it's clear to me that this fixes this failing test.
Comment #3
jaredsmith commentedNow that the patch from #2425127: Prevent PostgreSQL from creating duplicated index names within schema has been committed, all test in the 'options' test group pass. Closing as fixed.
Test run started:
Monday, February 23, 2015 - 14:38
Test summary
------------
Drupal\options\Tests\OptionsFieldTest 21 passes
Drupal\options\Tests\OptionsDynamicValuesApiTest 3 passes
Drupal\options\Tests\OptionsDynamicValuesValidationTest 9 passes
Drupal\options\Tests\OptionsFormattersTest 10 passes
Drupal\options\Tests\OptionsSelectDynamicValuesTest 16 passes
Drupal\options\Tests\OptionsFloatFieldImportTest 33 passes
Drupal\options\Tests\OptionsWidgetsTest 211 passes
Drupal\options\Tests\OptionsFieldUITest 295 passes
Test run duration: 3 min