(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/user/templates/user.html.twig
core/modules/user/templates/username.html.twig

CommentFileSizeAuthor
#1 copy_user_templates_to-2349771-1.patch3.27 KBlauriii

Comments

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new copy_user_templates_to-2349771-1.patch3.27 KB
mortendk’s picture

mortendk commented
Issue tags: +drupalhagen
runand’s picture

runand commented
Assigned: Unassigned » runand
runand’s picture

runand commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me

runand’s picture

runand commented
Assigned: runand » Unassigned
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Needs review

I'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

mortendk’s picture

mortendk commented
Status: Needs review » Reviewed & tested by the community

the module do uses js classes but they are not effected by the 2 template: user.html.twig or username.html.twig
so setting this to be rtbc

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

The profile and username classes are used in bartik (so good).

Committed a06218c and pushed to 8.0.x. Thanks!

  • alexpott committed a06218c on 8.0.x 
    Issue #2349771 by lauriii | davidhernandez: Copy user templates to...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.