I find a small bug on filter module, a missed slash on code, and without this slash looks not good node edit page.

Before:
huge text

After:
after

CommentFileSizeAuthor
#3 has_slash.png81.96 KBcsakiistvan
#2 missing_slash_2349545_2.patch1.25 KBcsakiistvan
missing_slash.png142.85 KBcsakiistvan

Comments

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Issue summary: View changes
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review
StatusFileSize
new missing_slash_2349545_2.patch1.25 KB
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
StatusFileSize
new has_slash.png81.96 KB

attach the after picture, everything is normal
hash

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Priority: Normal » Major
Désiré’s picture

Désiré commented
Status: Needs review » Reviewed & tested by the community

seems good to me

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
commented

Works for me too. This only seems to affect the node editing form when CKEditor is not present.

#2346995: Invalid <code> tags in filter plugins is marked as a duplicate of this (though in fact it was created first - but since this is RTBC I closed that one instead).

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: missing_slash_2349545_2.patch, failed testing.

csakiistvan queued 2: missing_slash_2349545_2.patch for re-testing.

The last submitted patch, 2: missing_slash_2349545_2.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Does not apply anymore :/

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs work » Closed (duplicate)

#2346783

martin_q’s picture

martin_q
Primary language English
Location Leipzig, Germany | Manchester, UK
commented

When sprints get too big... :-S

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented

yepp, next time :D

yesct’s picture

yesct commented
Related issues: +#2346783: Code block in FilterAlign and FilterCaption not closed properly