Problem/Motivation

We are getting rid of several classes so node-preview class is removed.

Proposed resolution

We need to remove code related to that class in core/modules/node/node.preview.js file, for example.

Remaining tasks

Check if we use that class name somewhere else and remove/fix code according to the change.

Be sure to don't break anything ;)

CommentFileSizeAuthor
#4 remove-code-related-to-node-preview-class-2341995-4.patch1.11 KBPalashvijay4O

Comments

Palashvijay4O’s picture

Palashvijay4O commented

I am intrested in this issue

Palashvijay4O’s picture

Palashvijay4O commented
Assigned: Unassigned » Palashvijay4O
Palashvijay4O’s picture

Palashvijay4O commented

Can anyone elaborate the issue .

Palashvijay4O’s picture

Palashvijay4O commented
Status: Active » Needs review
StatusFileSize
new remove-code-related-to-node-preview-class-2341995-4.patch1.11 KB

Submitting a patch . Needs to be reviewed.

Palashvijay4O’s picture

Palashvijay4O commented
Status: Needs review » Fixed
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Fixed » Needs review

Don't think this should be fixed since that is for once code is committed.

Palashvijay4O’s picture

Palashvijay4O commented

Yes Sir actually i am a beginner so I don't know about this thing . I am very sorry for this .

risse’s picture

risse commented
Status: Needs review » Reviewed & tested by the community

This patch seems to work as expected, and it's the only place where node-preview class is mentioned. RTBC +1

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

But I think that JavaScript needs to be fixed, it was added for a reason…

#1440662: UX regression: Prevent links in node preview from being clicked

rteijeiro’s picture

rteijeiro commented
Assigned: Palashvijay4O » rteijeiro

I'm going to try and fix it.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Postponed

I think the other issue will and looks to be nearly RTBC. I posted there to see if this JS should be removed at the same time.

rteijeiro’s picture

rteijeiro commented
Status: Postponed » Closed (duplicate)

It's fixed in #1440662: UX regression: Prevent links in node preview from being clicked