Problem/Motivation

+++ b/core/includes/theme.inc
@@ -1779,15 +1781,6 @@ function template_preprocess_page(&$variables) {
-  // Set up layout variable.
-  $variables['layout'] = 'none';
-  if (!empty($variables['page']['sidebar_first'])) {
-    $variables['layout'] = 'first';
-  }
-  if (!empty($variables['page']['sidebar_second'])) {
-    $variables['layout'] = ($variables['layout'] == 'first') ? 'both' : 'second';
-  }
-

$variables['layout'] appears to be unused and undocumented.

Proposed resolution

Remove it

Remaining tasks

-Write a patch
-Make sure it doesn't break anything / testing

User interface changes

-

API changes

-

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iMiksu’s picture

Status: Active » Needs review
FileSize
696 bytes

I couldn't find any instances using this variable form *.twig files.

lauriii’s picture

Status: Needs review » Reviewed & tested by the community

I grepped everything and didn't find anything where this could be needed.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

These are not currently used, but I think they are set up because they could be very useful to contrib or custom themes.

malotor’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
FileSize
696 bytes

Same path here

tim.plunkett’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I'm saying I don't think we should do this. I don't know what "Same path here" means.

lauriii’s picture

Status: Postponed (maintainer needs more info) » Closed (duplicate)
malotor’s picture

Sorry! i wanted to say "patch"