This was driving me crazy ;) ;)

CommentFileSizeAuthor
#4 secondary_links_description_6.x.patch939 bytesDavid_Rothstein
secondary_links_description.patch2.55 KBDavid_Rothstein

Comments

keith.smith’s picture

keith.smith commented
Status: Needs review » Reviewed & tested by the community

Good catch.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

Ah! Things like this drive me nuts too. I've committed this to CVS HEAD. I'm moving this down to DRUPAL-6 for Gabor to review. Not sure he'll want to break translations to fix this. I leave that up to Gabor to decide.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Fixed

I think a missing dot is better not to warrant breaking translations here, I think it is subtle enough to not be an issue if we leave it as-is in Drupal 6. Not committed to Drupal 6.

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new secondary_links_description_6.x.patch939 bytes

Just to be really nitpicky.... the part of the patch that fixes the update function could still go into 6.x, I think. (Text that gets inserted during the Drupal 5->6 upgrade is never translated, right?) So people upgrading from Drupal 5 would get the fix, but fresh installations of Drupal 6 would have to do without the precious period ;)

Patch is attached.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Some people are judging Drupal 6's quality by the patches we "need" to apply between point releases. I am trying to mark these kind of fixes as "(very minor)", so to avoid us looking like having a buggy version (which we don't have). So all this said, I'd love if we could concentrate on fixing any important bugs, and not missing dots. Committed this one to Drupal 6.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.