The access control handler duplicates the procedural code in shortcut.module (or vice versa, of course). The access check logic itself is also very, very bizarre: shortcut access checking checks if the associated shortcut set exists, for example, but that's nonsensical, because a shortcut cannot exist without a shortcut set.

In short: clean up shortcut module's access checking. It'll be much simpler and less error-prone.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it's about refactoring old code
Issue priority Major task because it's refactoring of the old code
Disruption Not disruptive

Comments

valthebald’s picture

Issue summary: View changes
Status: Active » Postponed

Postponed as non-disruptive major task (according to the flowchart)

wim leers’s picture

+1, makes sense!

jibran’s picture

We have done some work here #2083123: Shortcut cleanup: Remove duplicated code and deprecate legacy functions. @Wim Leers if that issue addresses your concern then we can mark this duplicate. Or you can review that issue and we can make changes over there.

wim leers’s picture