The access control handler duplicates the procedural code in shortcut.module (or vice versa, of course). The access check logic itself is also very, very bizarre: shortcut access checking checks if the associated shortcut set exists, for example, but that's nonsensical, because a shortcut cannot exist without a shortcut set.
In short: clean up shortcut module's access checking. It'll be much simpler and less error-prone.
Beta phase evaluation
| Issue category | Task because it's about refactoring old code |
|---|---|
| Issue priority | Major task because it's refactoring of the old code |
| Disruption | Not disruptive |
Comments
Comment #1
valthebaldPostponed as non-disruptive major task (according to the flowchart)
Comment #2
wim leers+1, makes sense!
Comment #3
jibranWe have done some work here #2083123: Shortcut cleanup: Remove duplicated code and deprecate legacy functions. @Wim Leers if that issue addresses your concern then we can mark this duplicate. Or you can review that issue and we can make changes over there.
Comment #4
wim leersConfirmed, YAY!
See #2083123-115: Shortcut cleanup: Remove duplicated code and deprecate legacy functions.