Problem/Motivation

#2260121: PHPUnit Tests namespace of modules is ambiguous with regular runtime namespace (+ Simpletest tests) broke run-tests.sh.

PIFR/PIFT is not broken, which is why we didn't roll that issue back.

But, looking at https://github.com/drupal/drupal/blob/8.0.x/core/modules/simpletest/src/...

TestDiscovery::findAllClassFiles() explicitly looks for "Drupal\\$extension\\", which now does not match any of these.

Proposed resolution

Fix

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 2333747b.patch914 bytesjhedstrom
#7 interdiff.txt670 bytesjhedstrom
#1 2333747-phpunit-1b.patch845 bytestim.plunkett
#1 2333747-phpunit-1a.patch897 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2333747-phpunit-1a.patch897 bytes
new 2333747-phpunit-1b.patch845 bytes

Here are two possibilities.

Honestly, I'm not sure why we bother with preg_quote.

dawehner’s picture

dawehner
Primary language German
commented

This seems to be some forcing of using a standard?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: run-tests.sh ignores module phpunit tests (Drupal\Tests\$extension) » run-tests.sh ignores phpunit tests when using the --module flag
fabianx’s picture

fabianx commented

RTBC for a) or b). They are equivalent.

As we cannot easily test the test system and this is an edge case, this should be good to go.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Can we at least get some code comment on what is going on here.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt670 bytes
new 2333747b.patch914 bytes

Adds a code comment. I went with option b from above that removes preg_quote(). Back to RTBC?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Adds a code comment. I went with option b from above that removes preg_quote(). Back to RTBC?

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

Code comment looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 2e9db3e on 8.0.x 
    Issue #2333747 by jhedstrom, tim.plunkett: Fixed run-tests.sh ignores...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.