format_size(1024) currently returns "1024 bytes" when it would be a bit nicer to say "1 KB".

CommentFileSizeAuthor
common.inc_3.diff662 bytesdrumm

Comments

Bèr Kessels’s picture

Bèr Kessels commented

I could be wrong, but there are two checks for $size >= 1024 shouldnt the last one check for $size >= 1048576 ?

drumm’s picture

drumm
he/him
Location NY, US
commented

it should not be 1048576 since $size</code would have already been divided by 1024 once at that point. If that <code>if were an else if then you would have been correct.

dries’s picture

dries commented

Committed to HEAD.

Anonymous’s picture

(not verified) commented