Remove all FormState array access usages from EntityForm and ContentEntityForm as per #2310255: [meta] Remove ArrayAccess from FormState.

CommentFileSizeAuthor
#1 drupal_2315917_1.patch5.85 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new drupal_2315917_1.patch5.85 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2315917_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

Xano queued 1: drupal_2315917_1.patch for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

I don't know what happened. The patch still passes all tests.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Hmm. I've been working on usages of $form_state[] by the key, not by section. Please see #2316533: Add getValue/setValue/hasValue and isValueEmpty to FormState and #2315807: Remove support for path-based form redirects...

I'd much rather add the methods we need than just blindly switch to the get()/set().

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Fair enough. The reason I did it for these two classes is that they are base classes and they make unit testing child classes quite a pain.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

This is all fixed now by the other issue!