Problem/Motivation

For some obscure reasons contextual links just get added to system provided menus (tools, admin, etc.)
though skipped for custom menus, which though certainly could profit from them as well.

Proposed resolution

Adapt the logic to also include the other menus.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#9 interdiff-8-5.txt871 bytesidebr
#8 interdiff-8-5.patch871 bytesidebr
#8 menu_contextual-2314985-8.patch3.57 KBidebr
#6 2314985-5-after.png13.41 KBidebr
#6 2314985-5-before.png12.94 KBidebr
#5 menu_contextual-2314985-5.patch3.23 KBidebr
#3 menu_contextual-2314985-3.patch3.04 KBdawehner
#1 menu_contextual-2314985-1.patch7.41 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new menu_contextual-2314985-1.patch7.41 KB

Here is a patch.

Status: Needs review » Needs work

The last submitted patch, 1: menu_contextual-2314985-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new menu_contextual-2314985-3.patch3.04 KB

Yeah two patches at once. Let's adapt the test coverage to test this as well.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
idebr’s picture

idebr commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new menu_contextual-2314985-5.patch3.23 KB
idebr’s picture

idebr commented
StatusFileSize
new 2314985-5-before.png12.94 KB
new 2314985-5-after.png13.41 KB

Yes please, this is very useful for administration :)

Screenshot before:

Screenshot after:

Status: Needs review » Needs work

The last submitted patch, 5: menu_contextual-2314985-5.patch, failed testing.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new menu_contextual-2314985-8.patch3.57 KB
new interdiff-8-5.patch871 bytes

I updated the test added in #2379083: Regression (again): Menu contextual links no longer visible in menu blocks, when block caching is enabled to include the custom block id instead of the hardcoded assumption.

idebr’s picture

idebr commented
StatusFileSize
new interdiff-8-5.txt871 bytes

Status: Needs review » Needs work

The last submitted patch, 8: interdiff-8-5.patch, failed testing.

idebr’s picture

idebr commented
Status: Needs work » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This is really nice. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 33066b7 and pushed to 8.0.x. Thanks!

  • alexpott committed 33066b7 on 8.0.x 
    Issue #2314985 by idebr, dawehner: Always add contextual links to menu...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.