PHP notice in forum.module if $term is not loaded

This is a duplicate of #231337: conflict with Forum module?

Forum tries to replace all taxonomy links with own path at forum_link_alter
But image gallery already replaced own links with image_gallery_term_path
So we need different way to replace links or just to check term for existence!

      $tid = str_replace('taxonomy/term/', '', $link['href']);
      $vid = variable_get('forum_nav_vocabulary', '');
      $term = taxonomy_get_term($tid);
//      if ($term->vid == $vid) {
      if ($term && $term->vid == $vid) {

subscribing. where this fix should go? is it possible to post a patch file?

i would not dare to change the status of this issue, but considering that two major and very popular modules like forum and image modules are in conflict, may i set to critical. change back if i am wrong.

Patch applied - need testing!

boydjd, take a closer look to the problem! Patch is fixing a notice caused by error in code
Remember, if you trying to check a property of object you SHOULD first to check the OBJECT.

So read [#3] this notice is caused by hook_term_path - forum SHOULD BE fixed not all other modules that use this hook!

Come on, this is a PHP notice, not a critical error. Should use !empty() instead of plainly checking against the variable.

Also retitling.

I didn't find this issue (sorry...), so I posted a new one a while back: #335111: Forum causes notices with image_gallery

It has some more detailed analysis as well as a different patch — I don't think we should call taxonomy_get_term($tid) if $tid (the result of trying to remove 'taxonomy/term/' from the path) is not numeric, because if it isn't, we're outside of what we expect.

Suppose patch from #13 still actual so let's check this

result of taxonomy_get_term possible only Object or False so why not to check 'is there result?' before check it's properties

function forum_link_alter(&$links, $node) {
  foreach ($links as $module => $link) {
    if (strstr($module, 'taxonomy_term')) {
      // Link back to the forum and not the taxonomy term page. We'll only
      // do this if the taxonomy term in question belongs to forums.
      $tid = str_replace('taxonomy/term/', '', $link['href']);
      $vid = variable_get('forum_nav_vocabulary', '');
      $term = taxonomy_get_term($tid);                        //Here is $term set to Term-Object or False
      if ($term->vid == $vid) {
        $links[$module]['href'] = str_replace('taxonomy/term', 'forum', $link['href']);
      }
    }
  }
}

Yes, the assumption is that

$tid = str_replace('taxonomy/term/', '', $link['href']);

operates on something like taxonomy/term/NNN where NNN is a number (the $tid).

In the case of image_gallery.module, str_replace() operates on 'image/tid/NNN', returning the unchanged 'image/tid/NNN'. What's the point of calling taxonomy_get_term('image/tid/NNN')?

Made obsolete by #197864-13: forum module uses hook_link_alter instead of taxonomy_term_path hook.