Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
forms system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2008 at 16:48 UTC
Updated:
21 Jul 2008 at 18:55 UTC
The "wrapper" divs of checkboxes and radios do not have an ID associated with them. This makes client-side javascript and themeing difficult. The attached patch fixes this problem.
This is a D7 version of http://drupal.org/node/215301. I'm submitting it separately so that getting it into D7 is not waiting on getting it into D6.
| Comment | File | Size | Author |
|---|---|---|---|
| checkboxes_radios_id.patch | 2.56 KB | pukku |
Comments
Comment #1
orthoducks commentedIn the version 6.2 "Edit a node" form, this is true of many other visual elements as well: fieldsets, etc. I suspect that it applies to (at least) many visual elements in many forms throughout the system. In view of the example set by the Drupal core, it may need more emphasis in the coding guidelines.
Comment #2
moshe weitzman commentedIt is better practice to keep one issue for a patch and then let that issue flow from HEAd back down to prior releases. So please close this issue and move patch to #215301: Checkboxes/radios wrapper container does not get an 'id' attribute. I reviewed 215301 and it is RTBC IMO. The patch here has a question in the comments which should be answered or removed. We don't typically ask questions in our code.
Comment #3
moshe weitzman commentedI moved the patch to #215301: Checkboxes/radios wrapper container does not get an 'id' attribute