Problem/Motivation

After #2208115: Add DependencySerializationTrait is fixed, remove \Drupal\Core\Plugin\PluginBase as it was only ever used for string translation and dependency injection functionality, both of which will now be handled by easily reusable traits.

Proposed resolution

Remove the class and let plugins use the traits and extend \Drupal\Component\Plugin\PluginBase directly instead.

Remaining tasks

None.

User interface changes

None.

API changes

A slight API break, but this can be fixed by a simple find and replace. No code will have to be refactored.

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I don't think that's a good idea, people will forget to add at least the dependency trait which is not directly visible what it does and then it will end badly ;)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Closed (won't fix)

That sounds fair.