Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
plugin system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jun 2014 at 22:36 UTC
Updated:
29 Jul 2014 at 23:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #2
blueminds commentedFound only minor things:
Shouldn't these use isNegated()?
ContainerIterface seems not to be imported. Does this work because this special case does not occur during tests? Probably not that relevant as it will be removed with dependency serialization.
Comment #3
tim.plunkettGood feedback, thanks!
Comment #4
berdirThis looks good I think. Had to check why the type validation is removed, but it's a checkboxes element, form API already ensures that you can't submit anything that's not part of the selection. Also wtf at Language as Lang....
Comment #5
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
tim.plunkettThanks!