Problem/Motivation

Since #2228215: Remove module check in DrupalKernel, the DrupalKernel has the new flag $allowLoading which can be set in order to prevent that the kernel is loaded from the disk. This flag is automatically set by the updateModules() method.

Previously it was necessary to compare the list of enabled modules set by updateModules() to the one from the container loaded from disk.

Proposed resolution

Because the container is not loaded anymore during updateModules(), the module-list check can be removed. The same applies to the $newModuleList instance variable.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 2277445-remove-new-module-list-property.diff1.64 KBznerol

Comments

znerol’s picture

znerol commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2277445-remove-new-module-list-property.diff1.64 KB
znerol’s picture

znerol commented
Title: Remove newModuleList » Remove newModuleList instance variable from DrupalKernel and related check in initializeContainer
znerol’s picture

znerol commented
Issue summary: View changes
Related issues: +#2228215: Remove module check in DrupalKernel
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +API clean-up

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c711a45 and pushed to 8.x. Thanks!

  • Commit c711a45 on 8.x by alexpott: 
    Issue #2277445 by znerol: Remove newModuleList instance variable from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.