Problem/Motivation
I'm working on #1805054: Cache localized, access filtered, URL resolved, and rendered menu trees, and this is a soft blocker (hence this is marked major, because #1805054 is marked critical).
In #1805054, I have to make quite a few changes to MenuTree. But all of the active trail handling in there is unaffected… precisely because active trail handling is completely independent of dealing with menu trees!
The active trail is only used in some cases to help build the three, but the concept of "active trail" is:
- independent of building a menu tree itself
- a concept that some sites may want to override because it's slowing their website down unnecessarily
MenuTree is confusing enough as is, even without the active trail handling. Let's make MenuTree only about handling… menu trees.
Remaining tasks
None.
User interface changes
None.
API changes
A new menu_link.active_trail service, with the typical corresponding MenuActiveTrailInterface and MenuActiveTrail class.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | menu_active_trail-2271763-1.patch | 15.01 KB | wim leers |
Comments
Comment #1
wim leersComment #3
wim leersSigh,
postdrop: warning: uid=33: No space left on device…Comment #4
wim leers1: menu_active_trail-2271763-1.patch queued for re-testing.
Comment #6
dawehnerLet's block it on #2227441: New plan, Phase 1:Review the architecture and overall implementation proposal for menu links as plugins because this one is just major. In other words I am being an asshole asking for reviews.
Comment #7
pwolanin commentedReally, the path will be on #2, so postpone this issue until: #2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module
Comment #8
wim leersWorks for me, I just wanted an issue to track this.
Comment #9
wim leersThis was done as part of #2301273: MenuLinkNG part2 (no UI or conversions): MenuLinkTree API and unit tests.