Problem/Motivation

I'm working on #1805054: Cache localized, access filtered, URL resolved, and rendered menu trees, and this is a soft blocker (hence this is marked major, because #1805054 is marked critical).

In #1805054, I have to make quite a few changes to MenuTree. But all of the active trail handling in there is unaffected… precisely because active trail handling is completely independent of dealing with menu trees!
The active trail is only used in some cases to help build the three, but the concept of "active trail" is:

  • independent of building a menu tree itself
  • a concept that some sites may want to override because it's slowing their website down unnecessarily

MenuTree is confusing enough as is, even without the active trail handling. Let's make MenuTree only about handling… menu trees.

Remaining tasks

None.

User interface changes

None.

API changes

A new menu_link.active_trail service, with the typical corresponding MenuActiveTrailInterface and MenuActiveTrail class.

CommentFileSizeAuthor
#1 menu_active_trail-2271763-1.patch15.01 KBwim leers

Comments

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new15.01 KB

Status: Needs review » Needs work

The last submitted patch, 1: menu_active_trail-2271763-1.patch, failed testing.

wim leers’s picture

Status: Needs work » Needs review

Sigh, postdrop: warning: uid=33: No space left on device

wim leers’s picture

Status: Needs review » Needs work

The last submitted patch, 1: menu_active_trail-2271763-1.patch, failed testing.

dawehner’s picture

Let's block it on #2227441: New plan, Phase 1:Review the architecture and overall implementation proposal for menu links as plugins because this one is just major. In other words I am being an asshole asking for reviews.

pwolanin’s picture

wim leers’s picture

Works for me, I just wanted an issue to track this.

wim leers’s picture

Status: Postponed » Closed (duplicate)
Issue tags: -sprint