Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
menu system
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
16 May 2014 at 10:59 UTC
Updated:
27 May 2015 at 08:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
wim leersI suspect that
MenuTree:buildPageData()'s$only_active_trailparameter is obsolete, not being used anywhere anymore. Let's see if we can safely remove it. (All menu tests pass locally, but maybe something else fails.)Comment #2
wim leersComment #4
wim leersComment #6
wim leersComment #7
wim leersComment #9
wim leersComment #10
wim leersOops. That was against
8.x, not8.0.x…Comment #13
wim leersComment #14
wim leersComment #16
wim leersComment #17
wim leersComment #19
wim leersComment #20
wim leersComment #23
wim leersComment #24
wim leersComment #26
wim leersComment #28
wim leersComment #29
wim leersComment #30
wim leersComment #31
wim leersComment #33
wim leersRolled against
f5b0b26ee052355bc7e31730ca642d93a7b775af. Interdiff against #2273277-26: Figure out a solution for the problematic interaction between the render system and the theme system when using #pre_render.Comment #35
effulgentsia commentedSome fixes, but not all yet.
Comment #37
effulgentsia commentedMore fixes + workarounds for tests calling drupal_render() that probably shouldn't.
The remaining RenderTest fails are interesting: it has to do with the simulating of rendering a child element before the parent, which obviously Twig templates can do, e.g.:
The new stack approach of drupal_render() would therefore not bubble bar's information to foo, since from both a call stack perspective and a markup perspective, they are rendered as siblings. I think that should be ok though, since both would bubble up to whatever the parent of this template is. So, not sure if the test needs to be adjusted to simulate the situation we're interested in better, or if there's some real problem that it's uncovering.
I don't plan on working any more on this this weekend.
Comment #39
wim leersThis should fix the entity cache tags tests.
Comment #41
wim leersComment #43
wim leersComment #45
wim leersComment #46
wim leersComment #49
wim leers#33 and later will also implicitly fix #2168111: Allow drupal_render() to pass up #attached to parents :)
Comment #50
wim leersComment #51
wim leersComment #52
wim leersForgot one hunk in #51.
Comment #53
wim leers#37: this interdiff contains the solution. The problem was that we were simulating template rendering by manually calling
drupal_render()on a child. This used to work, but now that we use a stack-based approach to bubbling, it doesn't work anymore. The stack-based approach pushes an empty stack frame upon enteringdrupal_render(), then recurses, and finally bubbles. But because we were calling the child immediately, that empty stack frame for the parent didn't exist and hence bubbling would fail, hence the test would fail. So it turned out to not be that hard to fix: we can simply reuse the template I added for the bubbling test coverage in the first place :)Comment #58
wim leersComment #59
wim leersComment #60
wim leersComment #62
wim leersComment #64
wim leersComment #65
wim leersComment #68
wim leersComment #70
wim leersComment #72
wim leersComment #74
wim leersComment #76
wim leersComment #78
wim leersComment #80
wim leersComment #82
wim leersComment #83
wim leersComment #84
wim leersComment #86
wim leersComment #88
wim leersComment #90
wim leersComment #92
wim leersSame patch, but with
-D, to not list the contents of deleted files in the patch.The patch MUST apply, I think testbot is using an old checkout of 8.0.x…
Comment #94
wim leersI should've included #2350949: Add hook_page_attachments(_alter)() and deprecate hook_page_build/alter()… now it should apply.
Comment #96
wim leersOne of these times, by random chance, one of my patches will finally apply. I really don't know what's going on anymore. I feel again like the first time I was rolling a patch: very much lost.
Anyway, looks like testbot doesn't like git patches rolled with
-D: I see lots oferrors. Alas. Bigger patch it is.
Comment #98
wim leersComment #100
wim leersComment #102
wim leersComment #104
wim leersComment #106
wim leersComment #108
wim leersComment #110
wim leersComment #111
wim leersComment #114
wim leersInterdiff relative to #104.
Comment #116
wim leersComment #118
wim leersComment #120
wim leersComment #122
wim leersComment #124
wim leersComment #125
wim leersn00b.
Comment #127
wim leersComment #129
wim leersComment #131
wim leersChasing HEAD; straight reroll.
Comment #133
wim leersComment #134
wim leersComment #135
wim leersComment #137
wim leersComment #138
wim leersComment #139
wim leersComment #141
wim leersComment #142
wim leersComment #144
wim leersComment #145
wim leersMany more changes, but two child issues have landed, hence smaller patch.
Comment #147
wim leersOops, one file was missing.
Comment #149
wim leersComment #151
wim leersComment #153
wim leersComment #154
wim leersComment #156
wim leersComment #157
wim leersComment #158
wim leersComment #160
wim leersComment #162
wim leersComment #164
wim leers#1805054: Cache localized, access filtered, URL resolved, and rendered menu trees landed, closing.