Problem/Motivation

#2120871: Rename EntityListController to EntityListBuilder removed most but not all references to Entity Storage Controller. A few references in comment and one (unused) variable name were left in place.

Proposed resolution

Fix it.

Remaining tasks

none

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 drupal-the-last-storage-controllers-2248051-01.patch2.98 KBsutharsan

Comments

sutharsan’s picture

sutharsan commented
Status: Active » Needs review
StatusFileSize
new drupal-the-last-storage-controllers-2248051-01.patch2.98 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Note that PhpStorageFactory has nothing to do with entities but I'm ok with removing the term controller from there as well, just as we did it with config storage classes.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks a good clean-up

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit 5105b52 on 8.x by webchick: 
    Issue #2248051 by Sutharsan: Remove last references to Entity Storage...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.