Installation - Database name gets escaped for creation, but not for settings

The patch still applies, but we might need a test here, if possible.

Rerolled. Tagging also.

I've added a unit test that tests this method. I picked the mysql implementation, but it really doesn't matter since the method being tested is on the abstract class.

Some weird conflicts with testbot based on recent stream-wrapper commits, here's a reroll.

(Note, the TEST ONLY patch is the interdiff from #4.)

Argh. I should have been running the tests with the script. PHPUnit itself didn't pick up the missing namespace. The stream wrapper errors were unrelated.

Hmm, locally the phpunit tests were passing, but I tracked that down to a views test creating the t() function. These might not be unit-testable unless we refactor the install tasks a bit to use the string translation trait.

I'm bumping this back to needs review to see what other folks think about just getting the fix in without tests.

Not sure if this will be allowed, but since views does it, declaring the t() function here will get this test coverage. As mentioned above, the alternative is to us the string translation trait (but that requires quite a bit of refactoring of the install tasks--just adding the trait alone doesn't work).

+++ b/core/lib/Drupal/Core/Database/Install/Tasks.php
@@ -299,6 +299,11 @@ public function getFormOptions(array $database) {
+    // Verify database name.
+    if (preg_match('/[^A-Za-z0-9_.]+/', $database['database'])) {
+      $errors[$database['driver'] . '][database'] = t('The database name you have entered, %name, is invalid. The name can only contain alphanumeric characters or underscores.', array('%name' => $database['database']));
+    }
+

You're looking for characters which is not a dot but you're not writing that dots aren't allowed.

And I came to this issue since I realised that dots was also stripped, not only that it seemed to strip everything after the dot.
So trying to create database "example.database" ended up trying to create "example".

Normal is fine here - maybe major, but even then.

@catch recommended critical based on the behaviour I experienced, but would probably have to update this issue description.

I think, by forbidening the special characters in the database name as per #2443839: Drupal does not install when auto-creating the MySQL database with special characters, then this issue should be experienced anymore as a side-effect of not allowing special characters in DB name.

Closing the issue because an older one is already existing #2443839

I have summarized patches and conversations over there