Updated: Comment #0

Problem/Motivation

StringItem adds a 'length' value to its schema corresponding to its 'max_length' setting. This setting can be sourced in an annotation, however, in which case it is not a PHP integer, but a string. It is not explicitly casted to (int), thus it gets added to the schema definition as a string.

Proposed resolution

Add an explicit cast to (int) to the 'length' schema value in StringItem.

Remaining tasks

User interface changes

-

API changes

CommentFileSizeAuthor
#1 2209071-1-string-item-length-schema-int.patch693 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
2209071-1-string-item-length-schema-int.patch693 bytes

Here we go.

lhangea’s picture

lhangea CreditAttribution: lhangea commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.