Follow-up from #2084421: Phase 2 - Decouple book module schema from menu links
Berdir points out there are a few menu_link-related references in the code including in book_uninstall()
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2209035-8.patch | 5.93 KB | pwolanin |
| #9 | increment.txt | 2.33 KB | pwolanin |
Comments
Comment #1
pwolanin commentedComment #2
pwolanin commentedHmm, still referencing a theme function from menu.inc too. The suggestion is wrong there too - shoudl be bid, not nid.
Comment #4
pwolanin commentedMissed a pre-proccess function
Comment #5
berdir- I think the first one should mention the bookLinkTranslate() method now?
- The second is part of the menu_tree_data method, and should probably be updated too, or was that left like that for a reason?
- The others are fine, the use is removed in #2209029: Follow-up: clean up use statements in book module code.
Comment #6
pwolanin commentedFor the comment referencing menu stuff I was going to tackle more completely at #2209025: Phase 3 - Make the BookManager interface more coherent, move more code out of book.module. Changling that 1 reference to the menu_links table doesn't make sense without re-writing the whole doc block
So, this patch adds a fix correcting the comment to reference bookLinkTranslate()
Comment #7
jhodgdonThis is not a docs issue.
Comment #8
dawehnerJust wonder why we don't already create a twig template, which would open up another issue otherwise.
we could use static::bookLinkTranslate
Comment #9
pwolanin commentedThanks - here's with a template.
Comment #10
dawehnerWe could do more obviously, but let's stay with the these bits for now.
Comment #11
dries commentedCommitted to 8.x. Thanks.