CommentFileSizeAuthor
#3 2196897-2.patch1.62 KBdivesh.kumar
#1 2196897-1.patch1.5 KBdivesh.kumar

Comments

divesh.kumar’s picture

divesh.kumar commented
Assigned: Unassigned » divesh.kumar
Status: Active » Needs review
StatusFileSize
new 2196897-1.patch1.5 KB

Patch attached.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work

Please see the parent issue for why this approach is incorrect.

divesh.kumar’s picture

divesh.kumar commented
StatusFileSize
new 2196897-2.patch1.62 KB
divesh.kumar’s picture

divesh.kumar commented
Status: Needs work » Needs review
thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

looks good.

thedavidmeister’s picture

thedavidmeister commented
Assigned: divesh.kumar » Unassigned
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.