CommentFileSizeAuthor
#6 drupal_2196893_6.patch7.14 KBxano
#4 2196893-filter-check_plain.patch7.11 KBlongwave
#1 2196893-1.patch5.38 KBdivesh.kumar

Comments

divesh.kumar’s picture

divesh.kumar commented
Status: Active » Needs review
StatusFileSize
new 2196893-1.patch5.38 KB
thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2196893-1.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2196893-filter-check_plain.patch7.11 KB

#1 is missing a "use" statement and several references in filter.module itself.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

@longwave - good catch :)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new drupal_2196893_6.patch7.14 KB

Re-roll. Leaving to RTBC, as only the use statement could not be added to FilterUnitTest.php.

thedavidmeister’s picture

thedavidmeister commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Please, no. Can we have just one patch that converts all of these in one go?

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Postponed
ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Postponed » Closed (duplicate)

This was fixed on the meta