Remove drupal_write_record()

What about this implementation?

protected function doSave($id, EntityInterface $entity) {
    if (!$entity->isNew()) {
      $return = drupal_write_record($this->entityType->getBaseTable(), $entity, $this->idKey);
      $this->resetCache(array($entity->id()));
    }
    else {
      $return = drupal_write_record($this->entityType->getBaseTable(), $entity);
      // Reset general caches, but keep caches specific to certain entities.
      $this->resetCache(array());
    }

    return $return;
  }

Wouldn't that be db_insert()?

So all of the 3 remaining non-test usages in core of drupal_write_record() stem from menu links. Let's postpone this on #2084421: Phase 2 - Decouple book module schema from menu links, which will move menu links to ContentEntityDatabaseStorage, i.e. obsoleting MenuLinkStorage and EntityDatabaseStorage.

Was that the right issue? That issue has been fixed for months. :-)

I think you meant this #2277979: Menu link storage does not implement SqlEntityStorageInterface

Yep, unused now outside of tests :)

Beautiful.

And there was much rejoicing.

(yay...)

As much as I'd love to commit this I think we need a change record for this.

Yeah, wanted to do that, just wasn't fast enough :)

https://www.drupal.org/node/2340291 good enough?

Committed 3295e62 and pushed to 8.0.x. Thanks!