This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

The example code for hook_ranking() in node.api.php is incorrect.

        'arguments' => array(\Drupal::config('vote.settings').get('score_max')),

We're not concatenating the result of Drupal::config() with the result of get() here :). Should be Drupal::config()->get()

Proposed resolution

Fix code.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 2188145-fix-wrong-concatenation-2.patch595 bytesmalionek

Comments

malionek’s picture

Assigned: Unassigned » malionek
malionek’s picture

Assigned: malionek » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new595 bytes

Concatenation removed in line 908 of node.api.php and changed to '->'. Created patch

umar-ahmad’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.