accidentally in #2109035: Make access checkers (much) easier to find

CommentFileSizeAuthor
#1 drupal.aggregator.2187313.patch2.24 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new drupal.aggregator.2187313.patch2.24 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal.aggregator.2187313.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review

1: drupal.aggregator.2187313.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented
Issue tags: +Quick fix
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

merge conflicts--

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 44b98ff and pushed to 8.x. Thanks!

Less code++

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Fixed » Needs work
Issue tags: +Needs reroll

drupal.aggregator.2187313.patch no longer applies.

error: patch failed: core/modules/aggregator/aggregator.services.yml:8
error: core/modules/aggregator/aggregator.services.yml: patch does not apply
error: core/modules/aggregator/lib/Drupal/aggregator/Access/CategoriesAccessCheck.php: No such file or directory
twistor’s picture

twistor commented

Isn't that because you already committed it?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

Yup it is committed see #6. I think #7 is posted by @alexpott's bot. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.