This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

The documentation of Drupal\Core\Entity\EntityInterface::urlInfo() of still refers to paths in the links annotation. This should been referring to routes - see the annotation in Drupal\node\Entity\Node. Additionally the documentation refers to the function contact_category_uri which no longer exists. This could be changed to comment_uri.

Proposed resolution

Fix documentation

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 fix_urlInfo_doc-2186225-3-D8.patch944 byteslucastockmann

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Regarding the "if you are experienced" text at the top of this issue... I just checked to make sure, and there is most of a page of Drupal Core / Documentation / tagged "Novice" issues that need patches (Active/Needs Work). If you include non-Documentation issues, and still just in Core, the list of issues that need patches runs to 4 pages.

So ... We are not really short of Novice tasks, are we?

I personally would be happy if anyone, experienced or not, jumped in to fix any of the Novice issues. Can we not make this kind of text standard?

lucastockmann’s picture

lucastockmann commented
Assigned: Unassigned » lucastockmann
lucastockmann’s picture

lucastockmann commented
Status: Active » Needs review
StatusFileSize
new fix_urlInfo_doc-2186225-3-D8.patch944 bytes

Patch submitted..

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks! Examples straight out of Core in the docs are always nice. :)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

+1 for looking up the corresponding route names so we have realistic examples!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

from the original issue.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Entity/Feed.php
@@ -28,6 +28,12 @@
+ *   links = {
+ *     "canonical" = "aggregator.feed_view",
+ *     "edit-form" = "aggregator.feed_configure",
+ *     "delete-form" = "aggregator.feed_delete",
+ *     "edit-form" = "aggregator.feed_configure",
+ *   },

edit-form is repeated here can we remove it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@jibran that is a separate and new issue - created #2186847: Remove duplicate edit-form key in Drupal\aggregator\Entity\Feed

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again -- committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.